Merge pull request #27 from LedgerHQ/fix

[fix] NanoS SDK has a unique section
LedgerHQ · Mar 26, 2024 · 64e1a82 · 64e1a82
2 parents 9f0d05e + 25e58b0
commit 64e1a82
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 
+## [0.6.3] - 2024-03-26
+
+### Fixed
+
+- ledger-binary: NanoS SDK has a unique `target_version` section.
+
+
 ## [0.6.2] - 2024-03-26
 
 ### Fixed

diff --git a/src/ledgered/binary.py b/src/ledgered/binary.py
@@ -25,6 +25,7 @@ class Sections(Jsonable):
     target: Optional[str] = None
     target_id: Optional[str] = None
     target_name: Optional[str] = None
+    target_version: Optional[str] = None
 
     def __str__(self) -> str:
         return "\n".join(f"{key} {value}" for key, value in sorted(asdict(self).items()))

diff --git a/tests/unit/test_binary.py b/tests/unit/test_binary.py
@@ -22,21 +22,25 @@ def setUp(self):
             "sdk_version": "sdk_version",
             "target": "target",
             "target_id": "target_id",
-            "target_name": "target_name"
+            "target_name": "target_name",
+            "target_version": "target_version",
         }
 
     def test___init__empty(self):
         sections = B.Sections()
         self.assertIsNone(sections.api_level)
         self.assertIsNone(sections.app_name)
         self.assertIsNone(sections.app_version)
+        self.assertIsNone(sections.rust_sdk_name)
+        self.assertIsNone(sections.rust_sdk_version)
         self.assertEqual(sections.sdk_graphics, B.DEFAULT_GRAPHICS)
         self.assertIsNone(sections.sdk_hash)
         self.assertIsNone(sections.sdk_name)
         self.assertIsNone(sections.sdk_version)
         self.assertIsNone(sections.target)
         self.assertIsNone(sections.target_id)
         self.assertIsNone(sections.target_name)
+        self.assertIsNone(sections.target_version)
 
     def test___str__(self):
         sections = B.Sections(**self.inputs)