This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review and test carefully.
this intend to fixes #83 , race condition when calling multiple times methods, like for instance signing 2 transactions in parallel.
this also fixes #97 , allowing multiple apps possible to be instanciated on the same transport.
when you try to call something that is "lock protected" when another thing is running (let's say signMessage is running), it will throw an exception
"Ledger Device is busy (lock signMessage)"
.@sgehrman would you mind checking if this fixed it for you? I have released version
4.3.0-beta.d226ed3b
of each individual library on NPM that includes this PR changes.thanks