Preparing for 2.0.0: Ethereum integration #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhalilBellakrid
requested review from
hadronized,
pollastri-pierre and
teams2ua
hadronized
reviewed
Dec 31, 2018
core/src/wallet/ethereum/explorers/api/EthereumLikeTransactionsBulkParser.h
Show resolved
Hide resolved
| std::string getETHOperationUid(); | ||
| int32_t getStatus() override ; | ||
|
|
||
| void setHash(const std::string &hash) { |
There was a problem hiding this comment.
I recommend chaning the signatures to all set* functions to:
ERC20LikeOperation& set*…
So that you can add a return *this; at the end of each setter and enable chaining.
KhalilBellakrid
force-pushed
the
eth-rebase-upstream
branch
from
f5f5243
to
b965aa6
Compare
… zcash and zencash on Windows
…o sqlite database
… when using AccountCreationInfo make sure to passe only one (index, owner, pubKey, chainCode)
…fore explorer was not sending empty transfer_events for ETH txs)
…g it once the HSM is giving it to us
…pty while RLP serializaing
…ve that from user's side)
KhalilBellakrid
force-pushed
the
eth-rebase-upstream
branch
from
b965aa6
to
2b9c579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.