Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major CI Improvements #901

Merged
merged 78 commits into from Sep 9, 2022
Merged

Major CI Improvements #901

merged 78 commits into from Sep 9, 2022

Conversation

BertrandD
Copy link
Contributor

@BertrandD BertrandD commented Sep 6, 2022 •
edited

Add ccache to accelerate CI tests
For this, I had to remove nix as ccache is not working with nix on macos see branch nix_with_ccache

Create libcore JAR & publish it to github registry to be used in WD: https://github.com/LedgerHQ/ledger-wallet-daemon/pull/502

BertrandD and others added 30 commits August 31, 2022 15:10
@BertrandD
Add ccache to github actions builds
1199b8b
@BertrandD
incrase cache size
88990bc
@BertrandD
Add ccache to buildInputs
5f38d1a
@BertrandD
Try to remove nix to build & run tests
bc379b2
@BertrandD
run on all branches on push
1220678
@BertrandD
run on all branches on push
f7b2fc1
@BertrandD
fix image name
e24c974
@BertrandD
use other credentials ?
6da4efb
@BertrandD
fix cli
e48fce2
@BertrandD
Use ninja
0a17f0d
@BertrandD
Use sys ssl
516d159
@BertrandD
add postgres service
05a3899
@BertrandD
temporarily change url for tests
083b548
@BertrandD
build postgres url from env
860f2c5
@BertrandD
Add macos build
17bbb8b
@BertrandD
Try to fix macos build
4fd4ac6
@BertrandD
Upload cmake artifacts
f0e578b
@BertrandD
add PGsql include dir
f51407b
@BertrandD
Rollback to pg 13
4cb164e
@BertrandD
Rollback to pg 13 on macos
415d1e2 
It seems to be related to update on brew package 14.5: Homebrew/homebrew-core@8060df9
@BertrandD
Rollback to pg 13 on macos
2fc8c2a 
It seems to be related to update on brew package 14.5: Homebrew/homebrew-core@8060df9
@BertrandD
Enable unixes
371f59a
@BertrandD
Cancel previous macos runs
b974a4b
@BertrandD
Remove ccache from nix_release_builds.yml
77c9260
@BertrandD
don't use sys openssl on macos
6cc934f
@BertrandD
Revert "don't use sys openssl on macos"
9840d93 
This reverts commit 6cc934f.
@BertrandD
fix db connection on macos
c44d94e
@BertrandD
fix incldue path
b245163
@BertrandD
Merge branch 'fix_macos_build' into ci_improvements
52186d9
@BertrandD
Keep circleci only on main
8b8c47e
@BertrandD BertrandD changed the base branch from ci_improvements to main September 7, 2022 09:13
@BertrandD BertrandD changed the title Package & publish libcore jar CI Improvements Sep 8, 2022
@BertrandD BertrandD changed the title CI Improvements Majro CI Improvements Sep 8, 2022
@BertrandD BertrandD changed the title Majro CI Improvements Major CI Improvements Sep 8, 2022
jcoatelen-ledger
jcoatelen-ledger requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the most comment is on java version to check which seems too restrictive, otherwise it's optional changes

README.md Outdated Show resolved Hide resolved
tools/publish-jar-local.sh Show resolved Hide resolved
tools/publish-jar-local.sh Outdated Show resolved Hide resolved
tools/publish-jar-local.sh Outdated Show resolved Hide resolved
tools/publish-jar-local.sh Show resolved Hide resolved
core/test/common/test_config.h Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@BertrandD BertrandD merged commit 1842b11 into main Sep 9, 2022
@BertrandD BertrandD deleted the package_jar branch September 9, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoatelen-ledger jcoatelen-ledger jcoatelen-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BertrandD @jcoatelen-ledger