Skip to content

Commit

Permalink
Merge pull request #184 from LedgerHQ/fbe/hotfix_navigate_with_scenario
Browse files Browse the repository at this point in the history
[Hotfix] issue when using the custom_screen_text parameter in navigator
  • Loading branch information
fbeutin-ledger committed Apr 15, 2024
2 parents 928ce2b + 9b6cd73 commit 3fd293e
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.18.1] - 2024-04-15

### Fixed
- navigator: fixed issue when using the custom_screen_text parameter

## [1.18.0] - 2024-04-12

### Added
Expand Down
8 changes: 4 additions & 4 deletions src/ragger/navigator/navigation_scenario.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,28 +85,28 @@ def review_approve(self,
custom_screen_text: Optional[str] = None,
do_comparison: bool = True):
scenario = NavigationScenarioData(self.device, UseCase.TX_REVIEW, approve=True)
self._navigate_with_scenario(scenario, path, custom_screen_text, test_name, do_comparison)
self._navigate_with_scenario(scenario, path, test_name, custom_screen_text, do_comparison)

def review_reject(self,
path: Optional[Path] = None,
test_name: Optional[str] = None,
custom_screen_text: Optional[str] = None,
do_comparison: bool = True):
scenario = NavigationScenarioData(self.device, UseCase.TX_REVIEW, approve=False)
self._navigate_with_scenario(scenario, path, custom_screen_text, test_name, do_comparison)
self._navigate_with_scenario(scenario, path, test_name, custom_screen_text, do_comparison)

def address_review_approve(self,
path: Optional[Path] = None,
test_name: Optional[str] = None,
custom_screen_text: Optional[str] = None,
do_comparison: bool = True):
scenario = NavigationScenarioData(self.device, UseCase.ADDRESS_CONFIRMATION, approve=True)
self._navigate_with_scenario(scenario, path, custom_screen_text, test_name, do_comparison)
self._navigate_with_scenario(scenario, path, test_name, custom_screen_text, do_comparison)

def address_review_reject(self,
path: Optional[Path] = None,
test_name: Optional[str] = None,
custom_screen_text: Optional[str] = None,
do_comparison: bool = True):
scenario = NavigationScenarioData(self.device, UseCase.ADDRESS_CONFIRMATION, approve=False)
self._navigate_with_scenario(scenario, path, custom_screen_text, test_name, do_comparison)
self._navigate_with_scenario(scenario, path, test_name, custom_screen_text, do_comparison)
Binary file modified tests/snapshots/flex/waiting_screen/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/waiting_screen/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/waiting_screen/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 3fd293e

Please sign in to comment.