Adapting to new Speculos finger_touch API call.
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xchapron-ledger
previously approved these changes
May 6, 2024
lpascal-ledger
force-pushed
the
fix/touch_finger
branch
from
863f2ae
to
4d69882
Compare
|
|
Sorry @xchapron-ledger I needed to update one snapshot. |
xchapron-ledger
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this PR, the Speculos
finger_touchfunction has two new argumentsx2andy2.We need to explicit that the third argument used in ragger is the
delay, else it will implicitly understand that it isx2. This will break, asx2needs to be an integer, whereas thedelayis often a float.