Fix race screenshot race condition and ticker pause behavior #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xchapron-ledger
force-pushed
the
xch/fix-screenshot-race-condition
branch
from
3a74bff
to
5e700e7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
==========================================
- Coverage 45.01% 45.00% -0.02%
==========================================
Files 120 120
Lines 12020 12028 +8
Branches 964 964
==========================================
+ Hits 5411 5413 +2
- Misses 6274 6280 +6
Partials 335 335 ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
previously approved these changes
Apr 11, 2024
xchapron-ledger
force-pushed
the
xch/fix-screenshot-race-condition
branch
from
5e700e7
to
10f32bb
Compare
fbeutin-ledger
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.