Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: elrond family integration #133

Merged
merged 13 commits into from Apr 4, 2023
Merged

Feat: elrond family integration #133

merged 13 commits into from Apr 4, 2023

Conversation

RamyEB
Copy link
Contributor

@RamyEB RamyEB commented Mar 15, 2023

Elrond family integration

  • Created a new family
  • Added tests

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023 •
edited

🦋 Changeset detected

Latest commit: 27ff5aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@ledgerhq/wallet-api-core Minor
wallet-api-website Minor
@ledgerhq/wallet-api-client Patch
@ledgerhq/wallet-api-manifest-validator-cli Patch
@ledgerhq/wallet-api-manifest-validator Patch
@ledgerhq/wallet-api-server Patch
@ledgerhq/wallet-api-simulator Patch
wallet-api-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RamyEB RamyEB self-assigned this Mar 15, 2023
@vercel
Copy link

vercel bot commented Mar 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-api-wallet-api-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 2:56pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
wallet-api ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2023 2:56pm

@RamyEB RamyEB requested a review from a team March 15, 2023 15:27
@RamyEB RamyEB mentioned this pull request Mar 15, 2023
Closed
@RamyEB RamyEB mentioned this pull request Mar 15, 2023
Closed
3 tasks
@cksanders cksanders added the enhancement New feature or request label Mar 20, 2023
@JunichiSugiura JunichiSugiura marked this pull request as ready for review March 24, 2023 16:38
JunichiSugiura
JunichiSugiura previously approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@JunichiSugiura JunichiSugiura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunichiSugiura JunichiSugiura dismissed their stale review March 24, 2023 17:00

Forgot to fix test regarding to non-optional gasLimit

@RamyEB RamyEB merged commit bb79e38 into main Apr 4, 2023
4 checks passed
@RamyEB RamyEB deleted the feat/elrond_integration branch April 4, 2023 15:17
@github-actions github-actions bot mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cksanders cksanders cksanders approved these changes

@JunichiSugiura JunichiSugiura JunichiSugiura left review comments

Assignees

@RamyEB RamyEB

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RamyEB @cksanders @JunichiSugiura