Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Xpub Scan more easily configurable #14

Closed
glethuillier opened this issue Feb 25, 2021 · 2 comments
Closed

Make Xpub Scan more easily configurable #14

glethuillier opened this issue Feb 25, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@glethuillier
Copy link
Contributor

The configuration options are set in src/settings.ts.

Therefore, each time an end-user configures the tool, it has to be rebuilt.

A more user-friendly approach could be to make it a JSON (or, preferably, a YAML) file automatically parsed (and validated) when the user runs the tool.

@glethuillier glethuillier added enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2021
@twilgenbus-ledger
Copy link

I think you've recently added the library dot-env to the project? Using the .env could also be a clean way to set this configuration.

@glethuillier
Copy link
Contributor Author

@twilgenbus-ledger That could be a great idea indeed. Note that we also need to provide a default configuration: the tool should be operational even without any .env.

@glethuillier glethuillier changed the title Make xpub scan more easily configurable Make Xpub Scan more easily configurable Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants