Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop layout wastes a lot of horizontal space #187

Closed
TeknikalDomain opened this issue Feb 8, 2020 · 4 comments
Closed

Desktop layout wastes a lot of horizontal space #187

TeknikalDomain opened this issue Feb 8, 2020 · 4 comments

Comments

@TeknikalDomain
Copy link
Contributor

On desktop (aka widescreen), only the inner third of the screen is used for content, and the rest is wasted, empty space. This also includes the topnav, where buttons are rather crowded and packed together to fit into that vertical band. I would assume that the siteWidth configuration might affect this, but it does not.

(Using commit 3435478)

@Lednerb
Copy link
Owner

Lednerb commented Feb 8, 2020

Hey @TeknikalDomain

the siteWidth param within the _variables.scss file should indeed do the trick.

You have to rebuild the final .css file this way:

  1. update the _variables.scss file
  2. cd into the themes directory via terminal and run npm install
  3. run npm run production to update your changes to the final theme.css file

Keep in mind that this theme is not one with a floating width that adjusts automatically to all different screen sizes.
If you just edit the siteWidth variable you may get problems for users with smaller screens that are still bigger than the tablet view.

Another approach would be to configure a new breakpoint so the site adjusts for even bigger screen resolutions.

Please let me know if my response helps you for a fix and if so, how you fixed it.
Maybe we can integrate the changes to the codebase.

@TeknikalDomain
Copy link
Contributor Author

I will try that in a moment, but that does make me wonder, what is siteWidth in config.toml configuring?

@Lednerb
Copy link
Owner

Lednerb commented Feb 8, 2020

Ah okay. I've missed this actually.

In the last days I've begun a rewrite of the dependency management and in an earlier version of this theme the hugo extended version was used to build the SASS/SCSS files directly into the final CSS file.

I will update the example config.toml and the docs soon.

If I remember correctly, there was also the option to define the header color via config.toml - that will also not work any longer.

(The new Version 2 - not yet tagged and finally released, breaks some not often used functionaltities from Version 1.14.0)

@TeknikalDomain
Copy link
Contributor Author

I'll take it a temporary fix is to just checkout 1.14.0 instead of directly from master at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants