Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hugo global function and .URL deprecated #171

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

nonumeros
Copy link
Contributor

v 0.54 runs fine, v 0.55 (recently released) however, returns:

WARN: Page's .Hugo is deprecated and will be removed in a future release. Use the global hugo function.
WARN: Page's .URL is deprecated and will be removed in a future release. Use .Permalink or .RelPermalink. If what you want is the front matter URL value, use .Params.url.

WARN: Page's .RSSLink is deprecated and will be removed in a future release. Use the Output Format's link, e.g. something like: {{ with .OutputFormats.Get "RSS" }}{{ . RelPermalink }}{{ end }}.

the only warning left would be Page's .GetParam is deprecated and will be removed in a future release. Use .Param or .Params.myParam

this seems to fix it, the devs changed everything around

Copy link
Owner

@Lednerb Lednerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems valid,
Thank you for your contribution! 👍

What's about backwards compatibility?
Will these changes work with older hugo versions?

@nonumeros
Copy link
Contributor Author

What's about backwards compatibility?

What I do know is that v 0.54 seemed working fine with these changes. Also, v 0.53.

But all of that stopped with v 0.52 - unfortunately. I'm assuming that v 0.51 won' t work either.

@Lednerb
Copy link
Owner

Lednerb commented Apr 12, 2019

Ok, v.0.5.3 was released on 2018-12-24 so I think it's OK to break with older versions.

I will check the compatibility once by my own and we need to update the README.md for the minimum Version.

Maybe you can send the fix for that, so we can merge soon.

@nonumeros
Copy link
Contributor Author

done!

@Lednerb
Copy link
Owner

Lednerb commented Apr 12, 2019

Checked, works until minimum 0.53!

@Lednerb Lednerb merged commit c9c86fc into Lednerb:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants