Add QuillJSONField #36
Conversation
gokselcoban
commented
Feb 9, 2021
•
gokselcoban
commented
- Dependent to Image uploader support #35
- Related comment rewrite QuillField to inherit JSONField #27 (comment)
- Related issue [feature] make QuillField inherit JSONField #26
- TODO: Update the docs
* Fix content damage on validation error * Fix fixtures format and enable null values * Fixed non-saving data of dynamically created quills * Poetry fix * Setup fix Co-authored-by: Michał Dyczko <michal.dyczko@poczta.pl>
Update widgets.py
this allows the db backend to apply any optimizations it might want/need closes LeeHanYeong#26 Co-authored-by: proxi <51172302+3n-k1@users.noreply.github.com>
* Bump to Quill Version 1.3.7 Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln quilljs/quill#2438 Here is the change commit to fix the vuln in Quill quilljs/quill#2439 The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab * Adding JS/CSS include instructions from README.md Resolves issue [LeeHanYeong#33](LeeHanYeong#33)
There was a problem hiding this comment.
just a small question about the QuillField() function. also, i definitely think this change needs docs, and preferably some tests to make sure bad code (like mine) doesn't get through again. this is a pretty big change for library consumers, and they might not realize it
|
|
||
|
|
||
| def QuillField(*args, **kwargs): | ||
| return QuillTextField(*args, **kwargs) |
There was a problem hiding this comment.
is there a reason this returns a text field instead of a json field?
There was a problem hiding this comment.
Current users of the package, imports and uses QuillField which is based on text field. They may don't want to change the existing approach. It returns the text field for backward capability.
There was a problem hiding this comment.
fair point. i would just add a bit to the readme explaining the different fields so new users know what to use
|
thanks a bunch for putting in the work! it definitely looks a lot better, both on the backend and the frontend (you fixed a css bug i couldn't figure out! thanks!) i just had a few small suggestions for documentation/tests |
…nto image-uploader
…r into json-field
gokselcoban
force-pushed
the
json-field
branch
from
5be601c
to
b7ae2ea
Compare
|
everything looks good to me :) |
|
@void-witch Could you please take a look at issue 38? It looks like the new code is causing an issue. |
Return value itself that holds the data on POST requests
LeeHanYeong
force-pushed
the
master
branch
4 times, most recently
from
258ba27
to
26049ff
Compare
|
while using QuillJSONField, delta is still stringified. what am I missing? |
