Added more tests #22
Added more tests #22
Conversation
|
|
||
| test("Sizes", () => { | ||
| expect(createTestTable(["xs", "lg", "sm", "md", "xlg"])).toStrictEqual([ |
There was a problem hiding this comment.
I should make the testing table dependent on the size of the array passed to createTestTable; so we can have more sizes included rather than being limited to just five. Currently table-sort-js doesn't sort sizes; This could possibly be handy for eCommerce/Clothing websites.
| }); | ||
|
|
||
| test("Months", () => { |
There was a problem hiding this comment.
table-sort-js doesn't currently sort months shouldn't be too hard to add in though.
| }); | ||
|
|
||
| test("Release Versions", () => { |
There was a problem hiding this comment.
Nice, release version is a common thing that would be sorted. 👍
| }); | ||
|
|
||
| test("Weekdays (Expects week begins at Monday)", () => { |
There was a problem hiding this comment.
table-sort-js doesn't currently sort Weekdays shouldn't be too hard to add in though.
|
|
||
| // toBe for primitives like strings, numbers or booleans for everything else use toEqual(object) | ||
|
|
||
| test('Alpha - Capitalized ', () => { | ||
| expect(createTestTable(['Echo','Alpha','Bravo','Charlie','Delta'])).toStrictEqual(['Alpha','Bravo','Charlie','Delta','Echo']); | ||
| test("Alpha - Capitalized ", () => { |
There was a problem hiding this comment.
Changing to the vertical format makes sense. I don't have experience with setting up tests, well I guess I do now. 🧪
| @@ -1,35 +1,135 @@ | |||
| const createTestTable = require('./table'); | |||
There was a problem hiding this comment.
Using "over ' is probably personal preference; but sure let's go with " from now on.
Added a few more tests:
Considered adding sort by currency where
5euross > 5$ but thought of it as an overkill