Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode versions to v1.31.0, add collapes all. #197

Merged
merged 2 commits into from Mar 11, 2019
Merged

vscode versions to v1.31.0, add collapes all. #197

merged 2 commits into from Mar 11, 2019

Conversation

ZainChen
Copy link
Contributor

@ZainChen ZainChen commented Mar 9, 2019

@ZainChen
Copy link
Contributor Author

ZainChen commented Mar 9, 2019

collapes all

@jdneo
Copy link
Member

jdneo commented Mar 10, 2019

@ZainChen Thank you for your contribution.

The feature collapes all looks good to me, just on concern about it.

Could you make sure that 1.31.0 is the lowest version to support this API? Cuz by upgrading the engine version, all the users who are using VS Code lower than 1.31.0 could not use the extension anymore.

@ZainChen
Copy link
Contributor Author

The minimum version that supports this API is 1.30.1. Although the official 1.29.1 version pointed out the modifications, the interface appeared in version 1.30.1.
https://code.visualstudio.com/updates/v1_29
https://code.visualstudio.com/updates/v1_30

vscode version to 1.30.1
@ZainChen
Copy link
Contributor Author

The contribution version is changed to 1.30.1, you can prompt everyone to use the new version of vscode, everyone will like this feature.^_^

Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you for your contribution.

@jdneo jdneo merged commit b85611b into LeetCode-OpenSource:master Mar 11, 2019
@ZainChen
Copy link
Contributor Author

Thank you too, very happy to contribute to such a good expansion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants