Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LeetCode extension as an activity bar item instead of a panel in Explorer item #38

Merged
merged 2 commits into from
May 25, 2018

Conversation

ntt2k
Copy link
Contributor

@ntt2k ntt2k commented May 25, 2018

Add LeetCode extension as an activity bar item instead of a panel in Explorer item.

For some people with a lot of pre-existence extensions already bloated the Explorer, this PR separate Leetcode extension as an individual activity bar item for easier navigation.

capture

@jdneo jdneo self-requested a review May 25, 2018 05:09
@jdneo jdneo added the enhancement New feature or request label May 25, 2018
@jdneo jdneo added this to the 0.6.0 milestone May 25, 2018
@jdneo
Copy link
Member

jdneo commented May 25, 2018

Very cool! Thanks for the contribution @ntt2k.

Just one concern. could we use space instead of tab in the package.json?

@jdneo
Copy link
Member

jdneo commented May 25, 2018

Created an issue for this PR: #39

@ntt2k
Copy link
Contributor Author

ntt2k commented May 25, 2018

Yes, please. Thank you very much for accepting this.
You actually remind me one of the most famous developer's debate-->
https://www.youtube.com/watch?v=V7PLxL8jIl8

@jdneo
Copy link
Member

jdneo commented May 25, 2018

Haha, that's a classic debate.

Just want to make the indent same in this project.
Leave the choice to you when you are doing your own projects. 😄

package.json Outdated
"leetcode-cli": "2.5.1",
"opn": "^5.2.0"
},
"__metadata": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be a problem. Just curious about this field. Do you know where this field comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field could have come from vscode as I modified directly inside program's location on disk ".vscode\extensions" ... I think you can delete it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see...

Well I'm fine to change this myself, but I encourage that you can make the change directly in this PR, since this awesome feature is originally driven by you.

You can simply push the changes to your branch ntt2k:master then the PR here can automatically synced.

The changes we need to do are:

  • repleace tab to space
  • remove the __metadata fields in package.jon

Would you mind to do that? And please feel free to tell me if you have any question. 😄

@jdneo jdneo merged commit b839a5d into LeetCode-OpenSource:master May 25, 2018
@jdneo
Copy link
Member

jdneo commented May 25, 2018

Pretty cool! thanks.

ringcrl pushed a commit to ringcrl/vscode-leetcode that referenced this pull request Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants