Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Safari Desktop Compatibility #112

Closed
alexdanilowicz opened this issue Mar 21, 2021 · 4 comments
Closed

Fix Safari Desktop Compatibility #112

alexdanilowicz opened this issue Mar 21, 2021 · 4 comments
Assignees
@Teddarific
Labels
bug Something isn't working
Milestone
Marketing Site v0

Comments

@alexdanilowicz
Copy link
Collaborator

alexdanilowicz commented Mar 21, 2021 •
edited

Unreal in 2021 we still have this issue. 馃槅

Website has a few bugs on Safari:

  • SVG on footer is messed up
  • margins are super large (on Safari and Firefox)
  • while doing this issue, would be good to checkout Firefox as well (see comment below)

Production URL: https://leftonread.me/

Screen Shot 2021-03-20 at 7 45 23 PM

Screen Shot 2021-03-20 at 7 49 51 PM
@alexdanilowicz alexdanilowicz added bug Something isn't working very high priority (p0) labels Mar 21, 2021
@alexdanilowicz
Copy link
Collaborator Author

On Firefox, svg in footer looks fine, but the Unique Analytics margins are too very large like Safari:
Screen Shot 2021-03-20 at 7 56 44 PM

@alexdanilowicz alexdanilowicz changed the title Web - Fix Safari Compatibility Web - Fix Safari Desktop Compatibility Mar 21, 2021
@alexdanilowicz alexdanilowicz mentioned this issue Mar 21, 2021
Closed
2 tasks
@Teddarific
Copy link
Collaborator

The margins look ok to me, what margin specifically?

The SVG issue is probably the same as the mobile issue.

@Teddarific Teddarific added this to the Marketing Site v0 milestone Mar 21, 2021
@alexdanilowicz
Copy link
Collaborator Author

I feel like margin on Unique Analytics is very fat @Teddarific

@Teddarific Teddarific changed the title Web - Fix Safari Desktop Compatibility Fix Safari Desktop Compatibility Mar 21, 2021
alexdanilowicz added a commit that referenced this issue Mar 23, 2021
@alexdanilowicz
Fix Footer and Minor Lang Changes. Resolves #113 and #112
74c55ed
@alexdanilowicz alexdanilowicz mentioned this issue Mar 23, 2021
Merged
alexdanilowicz added a commit that referenced this issue Mar 23, 2021
@alexdanilowicz
Fix Footer and Minor Lang Changes (#114)
0fe1292 
Resolves #113 and #112
@alexdanilowicz
Copy link
Collaborator Author

Resolved by #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Teddarific Teddarific

Labels
bug Something isn't working
Projects
None yet
Milestone
Marketing Site v0
Development

No branches or pull requests
2 participants
@Teddarific @alexdanilowicz