-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate permissions on chat.db and .vcf #9
Comments
Yes, we can simply do something like:
The user is going to be prompted saying, "LEFT ON READ WOULD LIKE TO ACCESS YOUR COMPUTER" For contacts, there's a few cases. I think we are going to have to do this:
And then read the The user is going to be prompted saying, "LEFT ON READ WOULD LIKE TO ACCESS YOUR CONTACTS" Note, if the user has security software, they are going to additionally prompted with something like this (I saw this on 1/4 computers I tested). Popups like these are a tradeoff if we do not have the user manually copying the chat.db and manually create a .vcf file |
WIP PR which demonstrates this for the chat.db case is here: #10 The issue is that I'm not sure how this will look in a real packaged build until we follow these steps and sign + notarize the app |
Got it, thanks for the information. I can look into the signing & notarizing. @alexdanilowicz is this something that would be better to get sooner than later? Or are we confident that what we can reproduce in dev will be what we get when we package in prod? |
@Teddarific thanks for your response. We are not confident because I'm not sure how permissions will be treated on a production application. On the current dev application it's just "electron" than is asking for permissions. In prod, it will be "Left On Read", and I'd rather not take any chances. I'd vote to sign and notarize sooner rather than later. @Teddarific. It also be great motivation. Not that we need any 😉 |
Directly copy chat.db for user, update README, and add tests/ Resolves #9
It's going to important to know what the technical limitations are in terms of accessing a chat.db and .vcf
This will help address what the user flow will look like:
The text was updated successfully, but these errors were encountered: