[app] Improve Emoji Display #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improving the display of emojis by using the awesome unicode-emoji package, which is basically a massive dataset of emojis and their description. We use it in the frontend to detect if an emoji version is older than 12.1. This change be changed later to detect what is on the system. Resolves #30
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/leftonread/leftonread-web/Dt8P1ks1NHGZq4BNJeGepNonEJ3v [Deployment for 156ee56 canceled] |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Certain emojis sent/received over iMessage may not be on system yet. (iOS14 may have a new emoji, but the laptop's emoji system may not be up to date.) See #30
Solution
Improve the display of emojis by using the awesome unicode-emoji package, which is basically a massive dataset of emojis and their description (among other things). We use it in the frontend to detect if an emoji version is older than 12.1. We can change this later to detect what emoji version is on the system. And no more hard-coded emoji lists. Yay! 🐶 🎊
Resolves #30.
Screenshots
New
Old