Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support play subcommand #32

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Conversation

rleungx
Copy link
Contributor

@rleungx rleungx commented Mar 22, 2018

Resolves #1, #22, #23.
This PR roughly implemented the play subcommand. The play command supports both local files and remote files. It is same as cat did. But I prefer to move these pub function to somewhere else and also move the Error Type to another place.

Copy link
Owner

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great! We can add tests and refactor in a followup.

@LegNeato LegNeato merged commit 63af95a into LegNeato:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants