Reduce mixins duplication in codebase #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # legacy-fabric-entity-events-v1/1.8.9/src/main/java/net/legacyfabric/fabric/mixin/entity/event/ServerPlayerEntityMixin.java
|
Ready for review |
BoogieMonster1O1
approved these changes
Mar 6, 2024
...ommon/src/main/java/net/legacyfabric/fabric/impl/item/group/FabricCreativeGuiComponents.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Shrish Deshpande <shrish.deshpande@icloud.com>
BluCobalt
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some module have their mixins only in their versionned counterpart. It means each versionned counterpart has its own set of mixins.
In some case it is possible to use one mixin for all versions in the common part.
This pull request intends to apply this to the remaining modules that don't do it yet.