Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade go modules (fix secondary ratelimit) #193

Merged
merged 13 commits into from
May 9, 2023

Conversation

gal-legit
Copy link
Collaborator

What's being changed?

  1. update go modules.
  2. fix relevant code where the 3rd-party pkg broke compatibility (although we upgrade to the same major)

The purpose of this PR was to upgrade go-github-ratelimit to v1.0.3 to handle the x-ratelimit-reset header that GitHub started to use recently.

Trying to upgrade naively (go get -u) failed because a lot of indirect dependencies break compatibility. Instead, I used this snippet:
go get $(go list -f '{{if not (or .Main .Indirect)}}{{.Path}}{{end}}' -m all) to only upgrade the direct deps (and let them upgrade the indirect deps per need).
There are still 3 breaking changes that I had to handle, coming from out direct deps:

  1. go-gpt3 was renamed to go-openai.
  2. scorecard changed the function signature (name and a new param).
  3. go-gitlab added a new param in one case.

Is this PR related to an existing issue?

no.

Check off the following:

  • This PR follows the CONTRIBUTION.md guidelines
  • I have self-reviewed my changes before submitting the PR

@gal-legit gal-legit requested a review from a team as a code owner April 30, 2023 17:02
@noamd-legit noamd-legit merged commit 260a0c7 into main May 9, 2023
9 of 11 checks passed
@noamd-legit noamd-legit deleted the gofri/mod-updates branch May 9, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants