fix: upgrade go modules (fix secondary ratelimit) #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed?
The purpose of this PR was to upgrade go-github-ratelimit to v1.0.3 to handle the x-ratelimit-reset header that GitHub started to use recently.
Trying to upgrade naively (
go get -u
) failed because a lot of indirect dependencies break compatibility. Instead, I used this snippet:go get $(go list -f '{{if not (or .Main .Indirect)}}{{.Path}}{{end}}' -m all)
to only upgrade the direct deps (and let them upgrade the indirect deps per need).There are still 3 breaking changes that I had to handle, coming from out direct deps:
Is this PR related to an existing issue?
no.
Check off the following: