Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support old PATs #43

Merged
merged 3 commits into from
Nov 15, 2022
Merged

fix: support old PATs #43

merged 3 commits into from
Nov 15, 2022

Conversation

gal-legit
Copy link
Collaborator

What's being changed?

  • Add support for old-style PATs (without the ghp_ prefix)
  • Replace GITHUB_ENDPOINT => SERVEL_URL (better future compatibility for other SCMs)
  • Add --server-url as flag as well.
  • While at it, refactor cmd and the client initialization code.

Is this PR related to an existing issue?

fixing #42

Check off the following:

  • This PR follows the CONTRIBUTION.md guidelines
  • I have self-reviewed my changes before submitting the PR

@gal-legit gal-legit requested a review from a team as a code owner November 14, 2022 13:23
@gal-legit gal-legit changed the title feat: support old PATs fix: support old PATs Nov 14, 2022
@gal-legit gal-legit merged commit 24f8beb into main Nov 15, 2022
@gal-legit gal-legit deleted the gofri/fix_ghes_pat branch November 15, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamd-legit noamd-legit noamd-legit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gal-legit @noamd-legit