Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible finddom node fix #21

Closed
wants to merge 1 commit into from
Closed

Possible finddom node fix #21

wants to merge 1 commit into from

Conversation

zackify
Copy link
Member

@zackify zackify commented Mar 20, 2017

No description provided.

@dphaener
Copy link

@zackify That looks like it should work. I'll want to definitely pull it down and test it before merging. If that isn't calculating the size on the proper element, it's going to cause all sorts of problems.

@zackify
Copy link
Member Author

zackify commented Mar 20, 2017 via email

@dphaener
Copy link

@zackify Yeah but that cell is wrapped in a HOC, so......not 100% certain we will be referencing the same DOM node.

Copy link
Contributor

@gavmck gavmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String literal refs are depreciated now as far as I'm aware. Should be using the arrow function syntax instead.

Have submitted a pull request that addresses the same issue :)

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-string-refs.md

@zackify zackify closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants