find now supports more css selectors #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find now can now support this:
However, this creates a breaking change:
Class selectors are no longer stripped of leading "." . This is for consistency that selectors simply are selectors. This means that often you need to access elements using the key syntax:
this.elements[ ".class-test"]
. This also means some fancy es6 object destructuring won't work as well.I think it is VERY worth it. We've been using this project at my job, and I've found that more specific selectors are very useful for testing. I made a mixin to do this, but I also thought I'd attempt a PR with it. Tests passing, linter passing. Had to change a few tests due to the breaking changes noted above.