ftype -> get_internal_type(), deepcopy django settings #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix bug where `ftype` doesn't exist by using `get_internal_type()` which is part of the API since Django 1.7 * Fix bug where using `override_settings` will actually overwrite the global django settings See LegoStormtroopr#19
|
This is amazing! Thanks for the help @brad I'll get this in and up on pypi later this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Samuel,
I ran into the same issue as #19 and when I looked into it, I saw that the problem was when we try to output
field.ftypein the template, butftypeis a non-existant attribute. I changed it to useget_internal_type()and added atest_meatballto check that all the existing field types get output to the template (and a non-existent field type is not output). As a side effect of adding the new test, the tests ran in a different order and I found another bug where the global django settings were getting overridden permanently by settings inoverride_settings. I usedcopy.deepcopyto prevent this and wrote a new test which fails before the change and passes afterward.