New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branch provider #2
Conversation
#else | ||
Branch.setUseTestBranchKey(true) | ||
#endif | ||
guard let shouldUseTestKey = properties?[BranchProvider.ShouldUseTestKey] as? Bool, let isDebugEnabled = properties?[BranchProvider.IsDebugEnabled] as? Bool else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why those are required.. We need a more out of the box approach. By default setup
should also call initSession
. We can do this by setting a parameter such as delayInitSession
, to allow the metadata
setup. And initSession
should not take launchOptions
as parameter, but rather it should be stored internally from setup
, if delayInitSession
property is active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I added the parameter for session initialization handling. I also refactored launchOptions
handling.
We need the parameters ShouldUseTestKey
& IsDebugEnabled
to handle behavior based on the environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but they can have default values. :) Both should be false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.