add challenge/response #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is based on PR #12 with the following difference: instead of adding a --unlock option to lglaf.py I use an own executable. The reason is that within download mode you need to authenticate only ONCE ( - IF you need to) and afterwards you're able to exec every other action like partitions.py etc without doing it again (until you reboot into download mode again ofc).
|
The review comments from the other PR still applies, e.g. python 3 compat. Maybe consider giving @snoremaster3000 credit in the header of the new script for the discoveries? |
|
Hey, I think I based my script on @joeblowma 's C version. I remember doing some reversing on it but I wasn't able to get the complete algorithm and he/she shared so I went ahead and just translated it (kind of poorly too, I'm not an experienced coder). So I think @joeblowma should get the credit. Edit: Just looked through my inbox and this is definite the case, @joeblowma reversed it. |
|
This got taken care of in #27, if there are any issues please open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is based on PR #12 with the following difference:
instead of adding a --unlock option to lglaf.py I use an own executable.
The reason is that within download mode you need to authenticate
only ONCE ( - IF you need to) and afterwards you're able to exec every
other action like partitions.py etc without doing it again (until you reboot
into download mode again ofc).