Skip to content
This repository has been archived by the owner on Mar 29, 2020. It is now read-only.

package.json not commited in Yarn workspaces #105

Closed
Leko opened this issue Jul 27, 2018 · 0 comments · Fixed by #107
Closed

package.json not commited in Yarn workspaces #105

Leko opened this issue Jul 27, 2018 · 0 comments · Fixed by #107
Labels
Type: Bug Something isn't working

Comments

@Leko
Copy link
Owner

Leko commented Jul 27, 2018

Environment

  • Version: 0.4.7
  • package manager: yarn
  • directory structure: yarn workspaces

Overview

In yarn workspaces, send pull request successfully but only committed yarn.lock.

  hothouse:Engine Try to save: /Users/leko/.ghq/github.com/org/repo/modules/xxx/package.json +1ms
  hothouse:Engine Try to update dependencies in xxx with Yarn +0ms
  hothouse:Engine modules/xxx Set { 'package.json', 'yarn.lock' } +38s
  hothouse:Engine No updates available in: /Users/leko/.ghq/github.com/org/repo/modules/yyy. Skipped +0ms
  hothouse:Engine { allChangeSet: Set { 'package.json', 'yarn.lock' } } +0ms

I think the behavior is strange:

  hothouse:Engine modules/xxx Set { 'package.json', 'yarn.lock' } +38s

It should be modules/xxx/package.json not package.json.

Actual behavior

  hothouse:Engine { allChangeSet: Set { 'package.json', 'yarn.lock' } }

Expected behavior

  hothouse:Engine { allChangeSet: Set { 'modules/xxx/package.json', 'yarn.lock' } }

path.join(rootDirectory, "package.json"),

This line contains a bug.
It should be path.join(packageDirectory, "package.json") not path.join(rootDirectory, "package.json").

@Leko Leko added the Type: Bug Something isn't working label Jul 27, 2018
Leko added a commit that referenced this issue Aug 5, 2018
@Leko Leko mentioned this issue Aug 5, 2018
@Leko Leko closed this as completed in #107 Aug 6, 2018
Leko added a commit that referenced this issue Aug 6, 2018
- 🐛 Add guard for repository.url is missing
- 🐛 Do not try to fetch release information when repository url is missing
- 🐛 Add newline to updated package.json
- 🐛 Fix `package.json not commited in Yarn workspaces`
- 🐛 Swap argments

Fixed #103, #104, #105, #106
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant