Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added MaxMSP and Orca icons #77

Closed
wants to merge 2 commits into from
Closed

Conversation

mgxy0
Copy link

@mgxy0 mgxy0 commented Jun 6, 2024

@mgxy0 mgxy0 closed this Jun 6, 2024
@LelouchFR
Copy link
Owner

@mgxy0 why did you closed it ?

@mgxy0 mgxy0 reopened this Jun 6, 2024
@mgxy0
Copy link
Author

mgxy0 commented Jun 6, 2024

@LelouchFR Sorry, wrong pull request

Copy link
Author

@mgxy0 mgxy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace the maxmsp icons

Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interresting to first search a design for them.

orca could have a dark and light (and auto) theme, that matches other icons colors, because it's a little bit out of scope

@LelouchFR
Copy link
Owner

LelouchFR commented Jun 6, 2024

@mgxy0 on what are you doing your icons ?

@mgxy0
Copy link
Author

mgxy0 commented Jun 6, 2024

With a simple macos app from app Store... I thought it was enough to upload the svg file. I apologize for the error, what do you recommend I use?

@LelouchFR
Copy link
Owner

With a simple macos app from app Store... I thought it was enough to upload the svg file. I apologize for the error, what do you recommend I use?

I recommend you read the contribution guideline (use figma)

@josemateuss
Copy link
Contributor

@mgxy0 if you like, you can check the old merged PRs, its can also help you.

@mgxy0
Copy link
Author

mgxy0 commented Jun 6, 2024

orca-dark
orca-auto
max-auto
max-dark

i made this svg files with figma, but i don't understand how to continue.. I apologize again

@LelouchFR
Copy link
Owner

@mgxy0 can you send me the figma file, I'm going to give you instructions on it, will be easier

@josemateuss
Copy link
Contributor

@mgxy0 do you need help?

@mgxy0
Copy link
Author

mgxy0 commented Jun 15, 2024

maxmsp-light

maxmsp-dark

ok here are the final SVGs files

@josemateuss
Copy link
Contributor

@mgxy0 please, commit the icons

@LelouchFR
Copy link
Owner

I will close it since it's being stale for a very long time

@LelouchFR LelouchFR closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW ICON] MaxMSP [NEW ICON] Orca
3 participants