Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] ♻️ Abstract Movements #210

Open
Aang099 opened this issue May 18, 2024 · 0 comments · May be fixed by #219
Open

[FEATURE] ♻️ Abstract Movements #210

Aang099 opened this issue May 18, 2024 · 0 comments · May be fixed by #219
Assignees
Labels
enhancement New feature or improvement feature request New feature or request
Milestone

Comments

@Aang099
Copy link
Member

Aang099 commented May 18, 2024

Requested Feature

Abstract motion class that motion algorithms inherit from, similarly to the old refactor.

Motivation

There's a lot of repeated logic in the motion algs of v0.5, especially around async functionality. By having an abstract class, logic repeated across motions can be handled by the base class, making motion algorithms much easier to maintain, and make implementing new motion algorithms much simpler.

This will also enable for motion algorithms logic to be moved away from the Chassis class (see #208), and enables users to make custom motions without changing the LemLib source code.

@Aang099 Aang099 added enhancement New feature or improvement feature request New feature or request labels May 18, 2024
@Aang099 Aang099 added this to the Version 0.6 milestone May 18, 2024
@Aang099 Aang099 linked a pull request Jun 17, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement feature request New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants