Dont allow posts to deleted / removed communities. Fixes #1827 #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is also possible to comment in deleted/removed posts. Could you add a check for that as well while you're at it? And for federation, you can do these same checks in CreateOrUpdatePost::verify() and CreateOrUpdateComment::verify(). |
dessalines
commented
Oct 12, 2021
| @@ -56,6 +57,7 @@ impl PerformCrud for CreateComment { | |||
| let community_id = post.community_id; | |||
|
|
|||
| check_community_ban(local_user_view.person.id, community_id, context.pool()).await?; | |||
| check_community_deleted_or_removed(community_id, context.pool()).await?; | |||
There was a problem hiding this comment.
The comment check is here.
There was a problem hiding this comment.
I mean that it also needs to check here if the post was deleted/removed.
There was a problem hiding this comment.
K I added this, but I'm not exactly sure how to extract the post in the CreateOrUpdateComment::verify() function.
There was a problem hiding this comment.
You need to call self.object.get_parents()
dessalines
force-pushed
the
dont_allow_posts_to_deleted_or_removed_communities
branch
from
4ae3c30
to
ec9e359
Compare
Nutomic
reviewed
Oct 14, 2021
crates/apub/src/objects/comment.rs
Outdated
| @@ -73,7 +73,7 @@ impl Note { | |||
| Ok(&self.id) | |||
| } | |||
|
|
|||
| async fn get_parents( | |||
| pub async fn get_parents( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.