Fix husky fmt hook. #1868
Merged
Fix husky fmt hook. #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually changed this on purpose, but ran into the exact problem you mentioned and was gonna change it back. While were at it, i think we can change the cargo clippy command to use the default Rust version, there is no reason to force nightly (which means extra compilation time). |
|
k done. run to fix:
|
Nutomic
reviewed
Nov 1, 2021
.cargo-husky/hooks/pre-commit
Outdated
| @@ -1,9 +1,9 @@ | |||
| #!/bin/bash | |||
| set -e | |||
|
|
|||
| cargo +nightly fmt | |||
| cargo fmt -- --check | |||
There was a problem hiding this comment.
fmt needs to be run on nightly though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one shouldn't have slipped in. cargo-husky has no lint-staged like node, so running
fmton these doesn't stage the files at all, and will let you commit unformatted files. Making this a format check again to fix.