Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send notifications on post/comment edits #1925

Closed
realkinetix opened this issue Nov 19, 2021 · 6 comments
Closed

Don't send notifications on post/comment edits #1925

realkinetix opened this issue Nov 19, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@realkinetix
Copy link

Recently had an email notification when someone responded to a comment of mine.

And then 5 or 6 more email notifications as they edited and saved a bunch of times. The extra notifications seem unnecessary.

@realkinetix realkinetix added the bug Something isn't working label Nov 19, 2021
@dessalines
Copy link
Member

That might be unavoidable, because if they edited the comment, they might've added a mention. If we don't email edits, you might miss a mention.

@Nutomic
Copy link
Member

Nutomic commented Nov 19, 2021

This is fixed by #1914.

@Nutomic Nutomic closed this as completed Nov 19, 2021
@poVoq
Copy link

poVoq commented Nov 19, 2021

I think this also effects pure lemmy users.

Some of the edits were just tiny typo corrections like adding an "s". Maybe there could be some filter to send only emails when a significant enough edit is made?

@Nutomic
Copy link
Member

Nutomic commented Nov 19, 2021

Oh this is about notifications on the lemmy website? Then #1914 has nothing to do with it, my bad.

@Nutomic Nutomic reopened this Nov 19, 2021
@realkinetix
Copy link
Author

Well, the intention on opening this up was due to email notifications. I don't know that the site was harassing me, I didn't catch any notifications in the browser about it.

@dessalines
Copy link
Member

I wouldn't want to add any complicated logic to edit notifications, I'd rather them just be on or off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants