Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min title char count for post titles. Fixes #1854 #1940

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Fix min title char count for post titles. Fixes #1854 #1940

merged 3 commits into from
Nov 23, 2021

Conversation

dessalines
Copy link
Member

No description provided.

@Nutomic
Copy link
Member

Nutomic commented Nov 23, 2021 •
edited
Loading

At least the length check could be part of the regex, that would make it more consistent with the other checks.

Edit: the newline check should probably be done for actor names and displaynames as well.

@Nutomic
Copy link
Member

Nutomic commented Nov 23, 2021

Need to rebase. And at this point, it even seems useful to make a helper function for the \n checks etc.

@Nutomic Nutomic merged commit 4518187 into main Nov 23, 2021
dessalines added a commit that referenced this pull request Dec 8, 2021
@dessalines
Fix min title char count for post titles. Fixes #1854 (#1940)
40e4c6c 
* Fix min title char count for post titles. Fixes #1854

* Adding more newline checks for actors.

* Adding helper function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nutomic Nutomic Awaiting requested review from Nutomic Nutomic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dessalines @Nutomic