Fixing duped report view for admins. Fixes #1933 #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
reviewed
Nov 23, 2021
| .eq(post::community_id) | ||
| .and(community_moderator::person_id.eq(self.my_person_id)), | ||
| ), | ||
| ) |
There was a problem hiding this comment.
You are repeating this code 4 times, maybe you can extract it into a function.
There was a problem hiding this comment.
Can't unfortunately, the function input query is different for each of these, and it would be 2 pages of BoxedSelectStatement<....tons of table joins>
There was a problem hiding this comment.
Damn, i wish they could allow some kind of generics for diesel operations, would save us so much code.
Btw i just noticed that unit tests are failing.
There was a problem hiding this comment.
Ah, that pry has to do with my sort order change, I'll fix that in a sec.
dessalines
added a commit
that referenced
this pull request
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.