Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show read posts when in specific community or profile #1426

Open
3 tasks done
coelacanthfucker420 opened this issue Mar 4, 2024 · 4 comments
Open
3 tasks done

show read posts when in specific community or profile #1426

coelacanthfucker420 opened this issue Mar 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@coelacanthfucker420
Copy link

Pre-Flight checklist

  • Did you check to see if this issue already exists?
  • This is a single feature request. (Do not put multiple feature requests in one issue)
  • This is not a question or discussion. (Use https://lemmy.ml/c/jerboa for that)

Describe The Feature Request Below

when accessing certain communities or profiles to look for certain posts or comments I saw previously I will have to turn show read posts off and on. It can get pretty annoying if done repeatedly. It would be nice if the "show read posts" option only affected the subscribed, local, and all feeds or if it had a option to toggle this behavior

@coelacanthfucker420 coelacanthfucker420 added the enhancement New feature or request label Mar 4, 2024
@MV-GH
Copy link
Collaborator

MV-GH commented Mar 5, 2024

For this we would need changes in Lemmy, option to disable read in the API when fetching posts? Currently it is a global user setting

But I do wonder do we even want to hide read posts for retrieving a users post? @dessalines ?

@dessalines
Copy link
Member

dessalines commented Mar 5, 2024

It would be nice if the "show read posts" option only affected the subscribed, local, and all feeds or if it had a option to toggle this behavior.

I think adding a quick toggle, probably on the header 3-dot-more menu, would be best.

But I do wonder do we even want to hide read posts for retrieving a users post?

I believe we added some changes to not hide your own posts, but I'd have to double check. As far as adding a unread_only to GetPosts, I'd be fine with that, although its probably not too difficult to just save the user, then refetch. The other thing is that if we added a top toggle like that, it would conflict with the local_user_setting.

We'll eventually have to do the same thing for the post view mode anyway, since that's getting moved to the back end, and per account.

@MV-GH
Copy link
Collaborator

MV-GH commented Mar 5, 2024

I think adding a quick toggle, probably on the header 3-dot-more menu, would be best.

toggling read was already planned to be added in the "extended" FAB options (Whenever that gets implemented)

I believe we added some changes to not hide your own posts,

Yes this was done for saved (and your own profile?). But I wonder if we want this at all for any profile?

@dessalines
Copy link
Member

Hrm... might need to open up an issue in the lemmy back-end for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants