Fix comments uncollapsing when they're not supposed to #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
requested review from
dessalines,
alectrocute and
jsit
as code owners
|
Nice! No problems, I thought we shouldn't have been getting the callback there (for all comments) but I didn't realise it was just the equality being used. 🤦♂️ Good catch 👍 |
alectrocute
approved these changes
Jun 24, 2023
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 24, 2023
…ssage-updates * lemmy/main: (21 commits) Fix comments expanding when they're not supposed to (LemmyNet#1540) Remove federation worker count fix: Add triangle alert icon to language warning Refactor first load handling fix: Add aria-describedby for language warning Fix issue when navigating awat from settings Give function better name Cache post listings and restore listing state when using browser back navigation buttons. Change function name Make date distance format use correct verbiage Extract date fns setup Fix homepage `scrollTo(0, 0)` failing when document size changes. v0.18.0 v0.18.0-rc.8 Moved `!isBrowser()` check to `FirstLoadServer.isFirstLoad` Fix server-side rendering after first load. Remove unused dep Replace momentjs with date-fns added litely-compact changed where custom compact code goes ...
This was referenced Jun 24, 2023
|
@SleeplessOne1917 We have a similar issue with expanded post images being collapsed when upvoting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1510. Thank you @scme0 for giving me the information needed to fix it.