Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add user action buttons to post dropdown #1653 #1655

Merged

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jun 27, 2023

Fixes #1653

All the "user action" buttons are now in the dropdown, and all the confirmation dialogs for these actions show up in the removeAndBanDialogs area.

They could definitely stand to be sorted differently; currently they are sorted by the permissions required to show them, but it means that a lot of "postive" actions are next to "negative" actions, and a lot of "post-level" actions are next to "person-level" actions.

Screenshot 2023-06-27 at 7 45 20 PM

I started to reorganize these and then realized the permissions are really fragile and important not to screw up, so I didn't.

What's left is just the moving of everything into the right places without a difficult to read PR.

The dialogs need a ton of work -- for instance, here's all you see after clicking "transfer community":

Screenshot 2023-06-27 at 7 46 40 PM

But this PR should fix the bug of these items being really hard to even access since they were behind a dropdown.

@alectrocute
Copy link
Contributor

Screenshot 2023-06-27 at 4 44 54 PM

Maybe this is because it's not finished yet, but I don't see these options now upon testing.

@alectrocute alectrocute added this to the 0.18.1 milestone Jun 27, 2023
@jsit jsit marked this pull request as ready for review June 27, 2023 23:47
@jsit
Copy link
Contributor Author

jsit commented Jun 28, 2023

@alectrocute Are you still not seeing them? You should now.

@jsit jsit changed the base branch from main to release/v0.18 June 28, 2023 02:39
@jsit jsit changed the base branch from release/v0.18 to main June 28, 2023 02:39
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better.

One thing: add the capitalizeFirstLetter to ban_from_community

@jsit jsit enabled auto-merge June 29, 2023 00:03
@jsit jsit disabled auto-merge June 29, 2023 00:03
@jsit jsit enabled auto-merge (squash) June 29, 2023 00:03
@dessalines dessalines disabled auto-merge June 29, 2023 02:43
@dessalines dessalines merged commit a30c112 into LemmyNet:main Jun 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin/moderator option menu on PostListing extremely confusing
4 participants