Remove hard-coded getRoleLabelPill text foreground color classes
#1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alec Armbruster <35377827+alectrocute@users.noreply.github.com>
alectrocute
requested review from
dessalines,
SleeplessOne1917 and
jsit
as code owners
|
Ah, yes, the In fact I'm pretty sure Bootstrap 5 chooses the correct foreground color based on the |
SleeplessOne1917
approved these changes
Jun 27, 2023
jsit
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appendum to #1656.
I did more testing with
lightlyand discovered we really aught to just use the default foreground colors for these pills, which means not manually specifyingtext-black/text-white, and just letting Bootstrap pick the default. This keeps things looking good across themes, see pics below.