Add fixed width/height to PostListing thumbnail parent
#1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectrocute
requested review from
dessalines,
SleeplessOne1917 and
jsit
as code owners
|
I think a col-auto next to a col-9 col-sm-10 or whatever it is might not work always. Hold pleaase |
|
|
Even if they're both col-auto, it doesn't work; the content part can wrap. hold please 
|
jsit
reviewed
Jun 27, 2023
Co-authored-by: Jay Sitter <jsit@users.noreply.github.com>
|
Made further tweaks off your work, @jsit. 
|
jsit
suggested changes
Jun 28, 2023
dessalines
approved these changes
Jun 28, 2023
|
Let's get this merged soon if possible, @dessalines. |
|
@jsit Your review is still marked as need changes. Is the PR good to go now? |
jsit
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lemdevs!
I noticed our thumbnails were looking inconsistent, so made an attempt to keep everything 1:1, at 5rem*5rem.
Before:
After:
Let me know your thoughts and/or if there's a better way to accomplish this. Our thumbnail generating function is a little bit of a mess, could be a good opportunity for refactor here.
Thanks!