Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix focus ring styles for radio button toggles #1772 #1773

Merged
merged 8 commits into from Jul 4, 2023

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jul 3, 2023

Fixes #1772

Before

Screenshot 2023-07-04 at 3 36 29 PM

After

Screenshot 2023-07-04 at 3 35 21 PM

@jsit jsit mentioned this pull request Jul 3, 2023
4 tasks
jsit added 3 commits July 4, 2023 14:03
…ocus-1772

* lemmy/main: (25 commits)
  v0.18.1-rc.10
  Attempt to fix inability to logout from some instances (subdomains) (LemmyNet#1809)
  feat(theme): Vaporwave (LemmyNet#1682)
  fix: Revert smaller text size (LemmyNet#1795)
  Updated the regex for isAuthPath to reduce false positive hits (LemmyNet#1806)
  fix: Add focus border to markdown toolbar buttons
  fix: Add data-bs-theme attribute for user dark/light modes (LemmyNet#1782)
  v0.18.1-rc.9
  fix: Fix comment collapse and vote buttons not having focus style (LemmyNet#1789)
  Add missing modlog reasons (LemmyNet#1787)
  Fix search page breaking on initial load when logged in (LemmyNet#1781)
  feat: Add PR template (LemmyNet#1785)
  v0.18.1-rc.8
  Fix profile loading spinner
  fix: Break text on post titles so long words don't overflow
  fix: Move getRoleLabelPill to the only component that uses it
  fix: Remove unused hasBadges() function
  fix: Fix badge alignment and break out into component
  fix: Fix up filter row gaps and margins a little
  fix: Fix heading levels
  ...
@jsit jsit marked this pull request as ready for review July 4, 2023 19:27
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace all the double equals with triple equals and you're good.

src/shared/components/common/data-type-select.tsx Outdated Show resolved Hide resolved
src/shared/components/common/data-type-select.tsx Outdated Show resolved Hide resolved
src/shared/components/person/registration-applications.tsx Outdated Show resolved Hide resolved
src/shared/components/person/reports.tsx Outdated Show resolved Hide resolved
src/shared/components/person/reports.tsx Outdated Show resolved Hide resolved
src/shared/components/person/reports.tsx Outdated Show resolved Hide resolved
src/shared/components/person/reports.tsx Outdated Show resolved Hide resolved
src/shared/components/person/reports.tsx Outdated Show resolved Hide resolved
@jsit jsit changed the title fix: Fix focus ring styles for home toggles #1772 fix: Fix focus ring styles for radio button toggles #1772 Jul 4, 2023
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why lint is failing.

@jsit jsit enabled auto-merge (squash) July 4, 2023 21:19
@jsit jsit merged commit b45c245 into LemmyNet:main Jul 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus ring not shown for radio toggles
3 participants