Don't show login toaster upon user settings change #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectrocute
requested review from
dessalines,
SleeplessOne1917 and
jsit
as code owners
alectrocute
changed the title
SleeplessOne1917
approved these changes
Jul 4, 2023
Comment on lines
+1180
to
+1183
| UserService.Instance.login({ | ||
| res: saveRes.data, | ||
| showToast: false, | ||
| }); |
There was a problem hiding this comment.
This works for now, but I always found it odd how the flow for changing settings involves making a call to login. Ideally we'd be able to update the settings without doing that.
There was a problem hiding this comment.
Yeah its def a weird one, should probably be reworked sometime.
dessalines
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
showToastparam toUserService's instanceloginmethod.Screenshots