Remove lodash.merge dependency

[tiziodcaio]

Description

Remove lodash.merge dependency from webpack.config.js file, replacing it with using spread sintax

[SleeplessOne1917]

Have you tested this? Sometimes merge is needed because the spread syntax is only shallow merge but you need a deep merge.

[tiziodcaio]

Yes, I confirm everything work.

Tested adding these lines to webpack.config.js and running various tests

  console.log(mode)
  console.log(serverConfig)
  console.log(clientConfig)

Logs

Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
daniele@hp ~/g/lemmy-ui (main)> yarn run dev
yarn run v1.22.19
$ yarn build:dev --watch
$ yarn clean && node generate_translations.js
$ yarn run rimraf dist
$ /home/daniele/git/lemmy-ui/node_modules/.bin/rimraf dist
$ webpack --env LEMMY_UI_DISABLE_CSP=true --env COMMIT_HASH=$(git rev-parse --short HEAD) --mode=development --watch
{
  output: { filename: 'js/server.js' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] },
    RunNodeWebpackPlugin {
      isWebpackInWatchMode: false,
      isFirstRun: true,
      errorsInPrevCompilation: false,
      options: [Object]
    }
  ],
  entry: './src/server/index.tsx',
  target: 'node',
  externals: [ [Function (anonymous)], 'inferno-helmet' ]
}
{
  output: { filename: 'js/client.js', publicPath: '/static/3bcb328d/' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] },
    ServiceWorkerPlugin { config: [Object] }
  ],
  entry: './src/client/index.tsx'
}
^C⏎                                                                                                                                                                       
daniele@hp ~/g/lemmy-ui (main) [SIGINT]> yarn run dev
yarn run v1.22.19
$ yarn build:dev --watch
$ yarn clean && node generate_translations.js
$ yarn run rimraf dist
$ /home/daniele/git/lemmy-ui/node_modules/.bin/rimraf dist
$ webpack --env LEMMY_UI_DISABLE_CSP=true --env COMMIT_HASH=$(git rev-parse --short HEAD) --mode=development --watch
development
{
  output: { filename: 'js/server.js' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] },
    RunNodeWebpackPlugin {
      isWebpackInWatchMode: false,
      isFirstRun: true,
      errorsInPrevCompilation: false,
      options: [Object]
    }
  ],
  entry: './src/server/index.tsx',
  target: 'node',
  externals: [ [Function (anonymous)], 'inferno-helmet' ]
}
{
  output: { filename: 'js/client.js', publicPath: '/static/3bcb328d/' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] },
    ServiceWorkerPlugin { config: [Object] }
  ],
  entry: './src/client/index.tsx'
}
^C⏎                                                                                                                                                                       
daniele@hp ~/g/lemmy-ui (main) [SIGINT]> yarn run analyze
yarn run v1.22.19
$ webpack --mode=none
none
{
  output: { filename: 'js/server.js' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] },
    BundleAnalyzerPlugin {
      opts: [Object],
      server: null,
      logger: [Logger]
    }
  ],
  entry: './src/server/index.tsx',
  target: 'node',
  externals: [ [Function (anonymous)], 'inferno-helmet' ]
}
{
  output: { filename: 'js/client.js', publicPath: '/static/undefined/' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] },
    ServiceWorkerPlugin { config: [Object] }
  ],
  entry: './src/client/index.tsx'
}
^C⏎                                                                                                                                                                       
daniele@hp ~/g/lemmy-ui (main) [SIGINT]> yarn run build:prod
yarn run v1.22.19
$ yarn clean && node generate_translations.js
$ yarn run rimraf dist
$ /home/daniele/git/lemmy-ui/node_modules/.bin/rimraf dist
$ webpack --env COMMIT_HASH=$(git rev-parse --short HEAD) --mode=production
production
{
  output: { filename: 'js/server.js' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] }
  ],
  entry: './src/server/index.tsx',
  target: 'node',
  externals: [ [Function (anonymous)], 'inferno-helmet' ]
}
{
  output: { filename: 'js/client.js', publicPath: '/static/3bcb328d/' },
  resolve: {
    extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
    alias: {
      '@': '/home/daniele/git/lemmy-ui/src',
      '@utils': '/home/daniele/git/lemmy-ui/src/shared/utils'
    }
  },
  performance: { hints: false },
  module: { rules: [ [Object], [Object], [Object] ] },
  plugins: [
    DefinePlugin { definitions: [Object] },
    MiniCssExtractPlugin {
      _sortedModulesCache: [WeakMap],
      options: [Object],
      runtimeOptions: [Object]
    },
    CopyPlugin { patterns: [Array], options: {} },
    BannerPlugin { options: [Object], banner: [Function (anonymous)] },
    ServiceWorkerPlugin { config: [Object] }
  ],
  entry: './src/client/index.tsx'
}
^C⏎                                                                                                                                                                       
daniele@hp ~/g/lemmy-ui (main) [SIGINT]>