Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enlarge the video #232

Closed
kuba-orlik opened this issue Mar 31, 2021 · 3 comments
Closed

Option to enlarge the video #232

kuba-orlik opened this issue Mar 31, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@kuba-orlik
Copy link

Is your proposal related to a problem?

When posting a video (say, an mp4 file), it gets displayed in this small preview box:

image

The only way to enlarge it is to make it fullscreen.

Describe the solution you'd like

It'd be best if the video uploads were treated the same way as image uploads are - clicking on them causes them to enlarge, both in single post view, as well as on post lists view

@kuba-orlik kuba-orlik added the enhancement New feature or request label Mar 31, 2021
@dessalines
Copy link
Member

For mp4's, we're using the browser's native video player, that ensures it will work on all browsers. I'm not sure that I'd want that thumbnail being larger than anything else. I'm also not sure what a different player like video.js would give us either.

@kuba-orlik
Copy link
Author

Native player is not an issue here - the issue is how impractically small it is.

image

I can either view it in 100x60 tiny window or fullscreen, there's nothing in between. Compare it to how pictures are shown. At first they show an equally tiny thumbnail:

image

And clicking that thumbnail (or the "+" icon in the headline) causes the image to get bigger:

image

Having a similar "expand" option for mp4s would be a GREAT usability improvement

@alectrocute
Copy link
Contributor

Resolved in #1479.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants