Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local urls for community and user urls. #369

Closed
dessalines opened this issue Aug 13, 2021 · 6 comments
Closed

Use local urls for community and user urls. #369

dessalines opened this issue Aug 13, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@dessalines
Copy link
Member

From a pm:

when i am on lemmy.ml and enter !communism@lemmygrad.ml it generates [!communism@lemmygrad.ml](https://lemmygrad.ml/c/communism)

but i want the link to open on lemmy.ml so that someone on lemmy.ml who clicks it stays logged in and can subscribe, vote etc

really the link target for !communism@lemmygrad.ml has to be the local instance of the viewer, not the instance of the comment author

@dessalines dessalines added the enhancement New feature or request label Aug 13, 2021
@Nutomic
Copy link
Member

Nutomic commented May 13, 2022

Someone on Lemmy suggested a good hack for this: make the mention as [!communism@lemmygrad.ml](/c/communism) so it uses a relative url. I think it should be pretty easy to change what the editor generates in that case. Might need some backend changes too, but im not entirely sure how mentions are implemented.

@krestenlaust
Copy link
Contributor

Isn't this the same issue as #1048 ?

@rszyma
Copy link

rszyma commented Jun 16, 2023

No, this is a different issue. Or at least it started as a different issue, because the discussion of #1048 went off the initial topic.

@db0
Copy link

db0 commented Jun 16, 2023

Note that the relative workaround won't work when someone is visiting from kbin, as that expects "magazines" to be using the /m/ separator

@krestenlaust
Copy link
Contributor

When discussing Kbin, it could also be worth discussing what degree of interoperability with the rest of the fediverse this should have. As it stands now, lemmy doesn't interface very well with other fedisoftware, but what about mastodon user URLs? Should other services be opened separately, while Lemmy is instance-agnostic?

@Zetaphor
Copy link
Contributor

@dessalines This can be closed as resolved now that #1462 is merged

@Nutomic Nutomic closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants