Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator for hidden comments #999

Open
Nutomic opened this issue May 5, 2023 · 4 comments
Open

Indicator for hidden comments #999

Nutomic opened this issue May 5, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Nutomic
Copy link
Member

Nutomic commented May 5, 2023

Is your proposal related to a problem?

Users often get surprised because some comments seem to be missing under a post. This happens most often because comments dont have any language specified and are tagged as "Undetermined" language. So if that language isnt enabled in settings, lots of comments appear to be missing.

Describe the solution you'd like

To make users aware of this, it would be useful to show messages like the following:

  • 2 comments hidden in language Undetermined which is not enabled in your settings
  • 1 comment hidden in language French which is not enabled in your settings

Next to these messages there could be a button "temporarily show all messages". Additionally, clicking individual messages might enable the respective language. Helping users to view comments in "undetermined" language is clearly the priority here.

Similar messages could also be added to indicate hidden comments from bot accounts or blocked users.

@aschrijver
Copy link

I would mention that the Languages listbox in Settings would be more intuitive if it was a list of checkbox items. Now the way to select multiple languages is by holding the Ctrl-key and creating the multi-select, which is awkward and regular users may not readily think of.

@dessalines
Copy link
Member

Now the way to select multiple languages is by holding the Ctrl-key and creating the multi-select, which is awkward and regular users may not readily think of.

Its using a standard browser html multi-select, that's going to be dependent on the browser you're using.

Users often get surprised because some comments seem to be missing under a post. This happens most often because comments dont have any language specified and are tagged as "Undetermined" language. So if that language isnt enabled in settings, lots of comments appear to be missing.

The front-end user can't know about missing comments, unless we remove the language filtering on the back-end, and move all the language filtering to the front end. It has pros and cons, but would require more work for front-end devs to check the users languages, and scan every comment to see if its in their list, then add some kind of hidden indicator.

@hybridhavoc
Copy link

My recommendation is that Undetermined language posts be included by default, and that filtering out Undetermined language posts should be set to a separate toggle from the language selection setting.

@Nutomic
Copy link
Member Author

Nutomic commented Jun 2, 2023

With Lemmy 0.17.3 undetermined language is automatically always enabled.

LemmyNet/lemmy#2851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants