Specify minimum Rust version 1.57 (fixes #2333) #2334
Conversation
Nutomic
force-pushed
the
min-rust-version
branch
from
7026391
to
19e9aeb
Compare
Nutomic
changed the title
| @@ -9,7 +9,7 @@ platform: | |||
| steps: | |||
|
|
|||
| - name: prepare repo | |||
| image: clux/muslrust:1.59.0 | |||
| image: clux/muslrust:1.57.0 | |||
There was a problem hiding this comment.
Any reason for downgrading? I just checked clux, and they're up to 1.61.0
There was a problem hiding this comment.
To make sure we dont accidentally introduce a change which requires a newer Rust version. I suppose we could only run cargo check with 1.57, and clippy with latest stable, or something like that.
There was a problem hiding this comment.
Yep, I would def like to keep our actual images on the most updated one, there's pry optimizations we don''t want to miss out on.
There was a problem hiding this comment.
Well the Rust version for release builds is specified in docker/prod/Dockerfile, i didnt change anything about that.
Nutomic
force-pushed
the
min-rust-version
branch
2 times, most recently
from
7fe1c2b
to
18edf21
Compare
Nutomic
force-pushed
the
min-rust-version
branch
from
18edf21
to
45f838f
Compare
|
I tried to use clux/muslrust:1.61.0 for clippy but that gave weird errors, so i switched to official rust image for that step instead. Now its just a bit weird that clippy gives a wrong warning about unused clone which i dont get locally. |
Tested this, with 1.56 it doesnt compile, but 1.57 works. Only disadvantage is that the older compiler might give worse error outputs, and might have less clippy lints.