Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded images are not oriented according exif #2494

Closed
sam365724 opened this issue Oct 13, 2022 · 4 comments
Closed

Uploaded images are not oriented according exif #2494

sam365724 opened this issue Oct 13, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@sam365724
Copy link
Contributor

sam365724 commented Oct 13, 2022

Issue Summary

Bug in pictrs. Exif info is lost and not respecte for image orientation, add flag according https://stackoverflow.com/questions/19456036/detect-exif-orientation-and-rotate-image-using-imagemagick/19475281#19475281

@asonix Can this be fixed?

See also https://github.com/recurser/exif-orientation-examples and https://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/

Steps to Reproduce

  1. Upload an image with exif orientation info and pixels not orientated
  2. Check img after upload

Technical details

  • Please post your log: sudo docker-compose logs > lemmy_log.out.
  • What OS are you trying to install lemmy on?
  • Any browser console errors?
@sam365724 sam365724 added the bug Something isn't working label Oct 13, 2022
@asonix
Copy link
Collaborator

asonix commented Oct 13, 2022

I will look into this over the weekend.

@asonix
Copy link
Collaborator

asonix commented Oct 16, 2022

I've published pict-rs v0.4.0-beta.7 today which should auto-rotate images with exif orientation data.

@asonix asonix closed this as completed Oct 16, 2022
@LeaPhant
Copy link

This seems to still be a present bug, tested on lemmy.ml and feddit.de (https://feddit.de/post/785848) instances.

Here's the original file zipped:
IMG_90CW.zip

@asonix
Copy link
Collaborator

asonix commented Jun 11, 2023

what version of pict-rs is feddit.de running? pict-rs 0.4.0-rc.3 (latest) properly rotates the image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants