Send error message when rate limit is reached #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
rate-limit-error
branch
from
8fb89a0
to
dd6c222
Compare
dessalines
reviewed
Nov 3, 2022
crates/utils/src/rate_limit/mod.rs
Outdated
| // if rate limit was hit, respond with http 400 | ||
| Ok(ServiceResponse::new( | ||
| Ok(ServiceResponse::from_err( | ||
| LemmyError::from_message("error_rate_limited"), |
There was a problem hiding this comment.
The i18n string is "rate_limit_error"
dessalines
approved these changes
Nov 3, 2022
dessalines
force-pushed
the
rate-limit-error
branch
from
16ffe43
to
ed374c5
Compare
dessalines
force-pushed
the
rate-limit-error
branch
from
ed374c5
to
b5131a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending an empty response is security by obscurity, and very confusing for users. Better to give an actual error message.
LemmyNet/lemmyBB#38 (comment)