feat: allow all admins to purge content #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TKilFree
force-pushed
the
dev-feat-allow-admins-purge-content
branch
from
da2741d
to
31e1ada
Compare
Nutomic
approved these changes
Jun 23, 2023
Nutomic
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in issue: #2976
this removes the
is_top_admincheck from all purges, i've also deleted theis_top_adminfunction itself since it's no longer usedas an aside in relation to the safety concerns, i believe a long term solution to this would be moving from a coarse-grained role-based system, to a fine-grained permissions + role system, where permissions can be defined for pretty much every server interaction and roles are just named bundles of permissions which can be assigned to users